search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
397 stars 27 forks source link

Changing fonts breaks Android Schemes generation #33

Closed PrattiDev closed 1 year ago

PrattiDev commented 2 years ago

Describe the bug Once two or three text styles have their fonts changed, the plugin will no longer be able to generate Android Schemes, and will crash when attempting to do so.

To Reproduce Steps to reproduce the behavior:

  1. Change the font of two or three text styles. In this case, I used Display/Large, Medium, Small, and changed their font to Manrope.
  2. Attempt to generate Android Schemes from the context menu of Figma.
  3. The plugin will launch but crash almost instantly.

The error shown is as follows:

chrome_9EN7clXyM3

Expected behavior Android Schemes should ideally, update automatically, as per #13 . However, in this instance, the plugin should at least generate Android Schemes and update those color styles regardless of the font chosen.

Desktop (please complete the following information):

rodydavis commented 2 years ago

Yep this is a Figma issue I have been working on.

I am making sure to load the font but it still fails randomly.

Im working on improving the typography support