search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
416 stars 30 forks source link

Font picker background does not respect dark mode #344

Open yvvki opened 2 months ago

yvvki commented 2 months ago

When picking fonts at the website version of Material Theme Builder, the background does not change with the browser theme.

This is the default view of the picker when viewed as is on a browser with a light theme: image

However, upon changing to a dark theme (regardless the website dark/light mode), the background remains the same while the text becomes its dark variant: image

Expected behavior The background should change into their dark variant to accommodate the light text, in which are currently have poor visibility due to its low contrast.

Additional context It's worth to recap that this issue happened due to the browser theme, not the website dark/light mode. In browser like Mozilla Firefox, these is the example theme to reproduce this issue: image

rbalet commented 1 month ago

Happen also on

OS: iOS Browser Chrome Version 129.0.6668.70 (Official Build) (arm64)