search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
364 stars 28 forks source link

Font values differ to Kotlin #35

Closed tonyhallett closed 1 year ago

tonyhallett commented 2 years ago

Describe the bug The Typography generated by material theme builder ( and exported ) disagrees with Kotlin defaults.

To Reproduce Steps to reproduce the behavior:

  1. Generate Typography
  2. Check the values - for instance display large image
  3. Check against https://android.googlesource.com/platform/frameworks/support/+/refs/heads/androidx-main/compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/tokens/TypeScaleTokens.kt

Expected behavior Defaults agree with Kotlin defaults

display large should be -0.2 title medium should be 0.2 body medium should be 0.2

Desktop (please complete the following information):

Additional context The m3 docs https://m3.material.io/styles/typography/tokens also disagree with Kotlin ( and the Material Design Builder ). I have added an issue https://github.com/material-components/material-components/issues/104 but it is not in the docs site as I cannot find it. If you aware of the docs repo then please let me know.

rodydavis commented 2 years ago

Thanks for the feedback! I will look into the issue.

cc @jwill

jwill commented 1 year ago

Removed typography from generation as Compose is pinned to earlier version than ours. Will now fallback to their version.