search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
364 stars 28 forks source link

Export for angular-material #38

Closed danitag78 closed 3 weeks ago

danitag78 commented 2 years ago

Is it possible to add export for scss file to use with angular-material with extended colours?

rodydavis commented 2 years ago

I can look into adding sass/scss export!

Given the current css could you paste an example of the ideal layout?

yegor-pelykh commented 1 year ago

I need export for Angular Material too, as well as many other people.

kintz09 commented 1 year ago

I'm not using Angular, but would also love to be able to export the theme to Sass (scss preferred) instead of just css. Especially if there were some useful mixins available in that export.

Fitzchev commented 1 year ago

I don't see any progress here despite a PR from @twerske from last year still open. Is it likely to happen?

marc-wilson commented 1 month ago

+1. I'm kind of shocked there's no export option for angular. I was thinking there was some hidden theme option to load up the JSON export, but I'm not seeing anything there either.

Just seems like angular is up there in what would be considered a default export for something like this.

themocs commented 3 weeks ago

I think it's because they only support android development over desktop.

margeeta commented 3 weeks ago

Hey y'all, We decided to go with CSS export to support a wider range of instead of focusing on specific web frameworks.

themocs commented 3 weeks ago

@margeeta It's not planned support to SCSS file export? SASS it's was a great improvement over site personalization, why not make it available?

marc-wilson commented 3 weeks ago

@margeeta I understand your point, but it seems a bit contradictory. Google, the creator of the Material Design Specification, also owns Flutter and Angular. So, it would be logical to provide something tailored for Angular (you've done so for Flutter).

The purpose of the tool is to simplify theme customization and then allow easy export for integration with underlying technologies. You've achieved this for Flutter, which is understandable. Similarly, not doing so for Swift also makes sense. However, not having a similar solution for Angular is puzzling.

While there is a generic CSS file, it often requires substantial modification to work properly with the underlying application or framework. Given that Angular Material is commonly used with Angular, it would be more practical to avoid a generic CSS file for any web app (which isn’t always the case) and instead support frameworks that are inherently based on Material Design (like Angular and Flutter). Angular Material see's this css file as an anti pattern. There is a very opinionated/specific way to setup theming in order for it to work properly and follow the Material Spec to the T.

In my opinion, not supporting an Angular Material specific export is a significant oversight.