material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
363 stars 28 forks source link

primary colour is changed #58

Closed bpappin closed 2 years ago

bpappin commented 2 years ago

Describe the bug When you input a specific custom colour for your Primary, Secondary or Tertiary, the tool changes that colour to something else.

This happens in both the web version and the Figma version.

To Reproduce Steps to reproduce the behavior:

  1. Go to the Figmal plugin, or Web tool
  2. Click on "Primary" and change the colour to hex value #002949, and apply that.
  3. Check the value of the primary colour, it will have been changed to #0061A3.
  4. The value of the primary colour was changed from #002949 to #0061A3.

Expected behavior The tool should not change a custom colour when its directly specified.

Additional context This happens in both the web version, and the Figma version.

aisgbnok commented 2 years ago

Edit Upon closer inspection, my issues (#60 and #61) are unrelated.

As for this issue, @bpappin I believe this is expected behavior, at least for now. It uses your source color to generate a palette, which needs to meet certain requirements. Therefore your source color may not be directly used in the generated palette.

jwill commented 2 years ago

That is correct, it is currently expected behavior.