Inverse Primary color style missing

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.

https://material-foundation.github.io/material-theme-builder/

Apache License 2.0

398 stars 27 forks source link

Inverse Primary color style missing #6

Closed beingminimal closed 2 years ago

beingminimal commented 2 years ago

Describe the bug As we can see in below screenshot that on M3 website there is a mention of color "Inverse Primary" in theme generated by plugin.

To Reproduce Steps to reproduce the behavior:

Generate new theme from plugin and you can crosscheck that this color is not being generated as style.

Expected behavior This color style should be generated with plugin.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context Add any other context about the problem here.

rodydavis commented 2 years ago

Thank you for the feedback!

beingminimal commented 2 years ago

@rodydavis Please ping me once it's live in plugin, thank you.

rodydavis commented 2 years ago

Documentation reference: https://m3.material.io/styles/color/the-color-system/color-roles

beingminimal commented 2 years ago

@rodydavis i know it is there in M3 docs, but that colour is not being generated as figma style by figma theme generator plugin, so i have created this issue to solve this. So let me know when it will be solves. Thanks

rodydavis commented 2 years ago

Inverse primary and shadow added on the latest!

bpappin commented 2 years ago

so is there a workaround? they dont seem to be there in the web tool

NVLudwig commented 2 years ago

Hello @rodydavis, I'm still not seeing inverse colours in figma Plugin nor in the web theme builder. Has this feature been abandoned and the inverse colors deprecated(no documentation on how to generate these seems available)?

Edit: I do see them but only in the color pallet of the Figma file and not the Frames generated on Canvas, I believe that's the source of the confusion. Also the inverse colors don't seem to be on Canvas in the web tool either

NVLudwig commented 2 years ago

Hi @bpappin, So On a hunch I doubled checked the Figma plugin output and realized it does not generate a frame with the inverse colors for you to see BUT the colors are in the Figma color Pallet.

rodydavis commented 2 years ago

That is correct, it's not reflected on the diagram but they are available in styles.

The plug-in is not abandoned and is under active development.

NVLudwig commented 2 years ago

That is correct, it's not reflected on the diagram but they are available in styles.

The plug-in is not abandoned and is under active development.

Thanks for the quick confirmation!