material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
363 stars 28 forks source link

Reopening the plugin clobbers customised Secondary and Tertiary colours #65

Closed pbutterworth closed 1 year ago

pbutterworth commented 2 years ago

Describe the bug After creating a new theme, and customising the Secondary and Tertiary colours, reopening the pluging and switching to the Custom tab causes the secondary and tertiary colours to be clobbered back to the automatically generated colours.

To Reproduce Steps to reproduce the behavior:

  1. Create a new theme
  2. Open the Custom tab
  3. Change the Secondary and Tertiary colours to something other than the default generated colours
  4. Close the plugin
  5. Reopen the plugin
  6. Switch to the Custom tab. At this moment, observed that the Secondary and Tertiary colours revert the the original default generated colours.

Expected behavior The plugin should remember the customisations

Screenshots First time customising the theme: image

After reopening the plugin (but before switching to the custom tab: image

After clicking on the Custom tab. Note that the customised colours have reverted: image

Desktop (please complete the following information):

pbutterworth commented 2 years ago

Discovered a workaround: If you have more than one theme in the current file, after opening the plugin, choose a different theme (any one) from the drop-down, then pick the first theme again from the drop-down. This then opens the custom tab with the correct colours populated.

xingyanbin commented 2 years ago

rent file, after opening the plugin, choose a different theme (any one) from the drop-down, then pick the first theme again from the drop-down. This then opens th

I had the same problem today, wish has a solution for this.

butlerjason commented 1 year ago

I have the same issue and without a workaround, I can't use this for our design system.