material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
363 stars 28 forks source link

Displaying and exporting wrong colours #73

Closed steamedham544 closed 1 year ago

steamedham544 commented 2 years ago

Describe the bug

To Reproduce I'm trying to generate the following theme: https://m3.material.io/styles/color/the-color-system/color-roles

Primary: #3a691e Secondary: #55624c Tertiary: #19686a Neutral: #5d5f5a

Expected behavior

Screenshots Generated light theme

Generated dark theme

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Every time I export for Android I get some sort of default theme being created no matter what I change: material-theme.zip

macxtor commented 2 years ago

I agree, I'm having same problem

Nohus commented 1 year ago

Any update? This makes the tool useless since you can't actually export the theme you create in it.

jwill commented 1 year ago

I'm not able to reproduce this...do you happen to have multiple downloads blocked by default? Sometimes that will make downloads not act as expected.

Nohus commented 1 year ago

Here is what I'm doing:

The downloaded .zip file contains default colors, not the actual color scheme. It never changes regardless of the created color scheme.

jwill commented 1 year ago

And to confirm, you don't have multiple downloads blocked? Does a red x show up in URL bar with Download blocked or a similar message when you try to export?

Nohus commented 1 year ago

No download blocking, I get a successful new download every time I export. They all always contain the same colors regardless of the color scheme visible in the tool. If I export immediately after entering the page without making any changes, I do get the purple color scheme that is initially shown. As soon as I make any change to the colors, the downloaded theme always has the same color scheme that has nothing to do with the chosen colors:

I made a screen recording for you: https://streamable.com/f50vdh

ahmedre commented 1 year ago

I am able to 100% reproduce this in Safari on macOS, for example (though on Google Chrome, it works properly).

jwill commented 1 year ago

Fixed in recent push.

eygraber commented 1 year ago

This is either still happening, or happening again. I'm seeing the same exact behavior as described above. I set a primary, secondary, and tertiary color, but the primary color is used for secondary and tertiary as well.

This is happening in Chrome and Firefox in Ubuntu.

eygraber commented 1 year ago

Apologies, I misread. This is a similar, but different issue. I will open a new one.