material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
363 stars 28 forks source link

Exported Theme xml includes seed color twice #75

Closed tomermandelfw closed 2 years ago

tomermandelfw commented 2 years ago

Describe the bug When exporting a theme, it includes a twice, which causes a compilation error.

To Reproduce

  1. Go to 'The Material Theme Builder' (Custom tab)
  2. Click on 'Export' -> 'Android Views (XML)'
  3. Use the downloaded xmls. The colors.xml includes <color name="seed"> twice.
  4. Compilation error: Found item Color/seed more than one time

Example xml:

<resources>
    <color name="md_theme_light_surfaceTint">#6750A4</color>
    <color name="md_theme_light_surfaceTintColor">#6750A4</color>
    <color name="md_theme_light_onErrorContainer">#410E0B</color>
    <color name="md_theme_light_onError">#FFFFFF</color>
    <color name="md_theme_light_errorContainer">#F9DEDC</color>
    <color name="md_theme_light_onTertiaryContainer">#31111D</color>
    <color name="md_theme_light_onTertiary">#FFFFFF</color>
    <color name="md_theme_light_tertiaryContainer">#FFD8E4</color>
    <color name="md_theme_light_tertiary">#7D5260</color>
    <color name="md_theme_light_shadow">#000000</color>
    <color name="md_theme_light_error">#B3261E</color>
    <color name="md_theme_light_outline">#79747E</color>
    <color name="md_theme_light_onBackground">#1C1B1F</color>
    <color name="md_theme_light_background">#FFFBFE</color>
    <color name="md_theme_light_inverseOnSurface">#F4EFF4</color>
    <color name="md_theme_light_inverseSurface">#313033</color>
    <color name="md_theme_light_onSurfaceVariant">#49454F</color>
    <color name="md_theme_light_onSurface">#1C1B1F</color>
    <color name="md_theme_light_surfaceVariant">#E7E0EC</color>
    <color name="md_theme_light_surface">#FFFBFE</color>
    <color name="md_theme_light_onSecondaryContainer">#1D192B</color>
    <color name="md_theme_light_onSecondary">#FFFFFF</color>
    <color name="md_theme_light_secondaryContainer">#E8DEF8</color>
    <color name="md_theme_light_secondary">#625B71</color>
    <color name="md_theme_light_inversePrimary">#D0BCFF</color>
    <color name="md_theme_light_onPrimaryContainer">#21005D</color>
    <color name="md_theme_light_onPrimary">#FFFFFF</color>
    <color name="md_theme_light_primaryContainer">#EADDFF</color>
    <color name="md_theme_light_primary">#6750A4</color>
    <color name="seed">#6750A4</color>
    <color name="md_theme_dark_surfaceTint">#D0BCFF</color>
    <color name="md_theme_dark_surfaceTintColor">#D0BCFF</color>
    <color name="md_theme_dark_onErrorContainer">#F2B8B5</color>
    <color name="md_theme_dark_onError">#601410</color>
    <color name="md_theme_dark_errorContainer">#8C1D18</color>
    <color name="md_theme_dark_onTertiaryContainer">#FFD8E4</color>
    <color name="md_theme_dark_onTertiary">#492532</color>
    <color name="md_theme_dark_tertiaryContainer">#633B48</color>
    <color name="md_theme_dark_tertiary">#EFB8C8</color>
    <color name="md_theme_dark_shadow">#000000</color>
    <color name="md_theme_dark_error">#F2B8B5</color>
    <color name="md_theme_dark_outline">#938F99</color>
    <color name="md_theme_dark_onBackground">#E6E1E5</color>
    <color name="md_theme_dark_background">#1C1B1F</color>
    <color name="md_theme_dark_inverseOnSurface">#313033</color>
    <color name="md_theme_dark_inverseSurface">#E6E1E5</color>
    <color name="md_theme_dark_onSurfaceVariant">#CAC4D0</color>
    <color name="md_theme_dark_onSurface">#E6E1E5</color>
    <color name="md_theme_dark_surfaceVariant">#49454F</color>
    <color name="md_theme_dark_surface">#1C1B1F</color>
    <color name="md_theme_dark_onSecondaryContainer">#E8DEF8</color>
    <color name="md_theme_dark_onSecondary">#332D41</color>
    <color name="md_theme_dark_secondaryContainer">#4A4458</color>
    <color name="md_theme_dark_secondary">#CCC2DC</color>
    <color name="md_theme_dark_inversePrimary">#6750A4</color>
    <color name="md_theme_dark_onPrimaryContainer">#EADDFF</color>
    <color name="md_theme_dark_onPrimary">#381E72</color>
    <color name="md_theme_dark_primaryContainer">#4F378B</color>
    <color name="md_theme_dark_primary">#D0BCFF</color>
    <color name="seed">#6750A4</color>
</resources>

Expected behavior The xml should only include each color attribute once.

jwill commented 2 years ago

Thanks for the report. Fixed.