search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
363 stars 28 forks source link

Card colors do not update in latest version #77

Closed cedvdb closed 1 year ago

cedvdb commented 2 years ago

Describe the bug

Cards color do not update in the material design kit

To Reproduce Steps to reproduce the behavior:

  1. Go to material theme builder
  2. open material plugin
  3. Make new theme
  4. Swap cards to new them

Expected behavior Cards background changed

I say cards but you can select everything in styles and component section and see what does not change... About 1/3 of all items do not change, so it's quite unusable as it stands.

Some examples (green theme):

image

image

cedvdb commented 2 years ago

cc @rodydavis

PrattiDev commented 1 year ago

This is because there's a new token structure the plugin is built to work off of, but existing kits with the old tokens will not work properly.

The current UI kit has surfaces under read-only, whereas the new plugin requires them to be in theme/surfaces/light or theme/surfaces/dark.

The new structure for surfaces

rodydavis commented 1 year ago

Please select the old cards and hit swap. It will migrate them from read only