material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
363 stars 28 forks source link

Is that expected behavior that updates natural color drastically? #84

Closed sundaycrafts closed 1 year ago

sundaycrafts commented 1 year ago

Describe the bug

On Material theme builder on the Web and Figma plugin, the natural color changes drastically when I modify its parameter. And I can't restore the default color palette.

To Reproduce Steps to reproduce the behavior (see screen shot below):

  1. Go to Material theme builder on the Web
  2. Click on "Neutral"
  3. Change the Hue value by 1 point.
  4. Neutral color is drastically changed.

Expected behavior I don't know if this is expected behavior or not. But users must expect to restore the default state, at least.

Screenshots [Default color paletto] image

[After Updated 294 (293.03761206699426 as precise) -> 293] image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context NA

andaja commented 1 year ago

I was stuck at this as well. on the web and in Figma plugin it wrests chroma/saturation unpredictably high for most colors probably mostly when the primary is saturated. Especially enigmatic is the sudden switch to bright cyan if chroma = 0.

On a related note, it tunes the hue of the some colors +/- but I expect it can be due to some special perceptive magic. Though it looks like the mid-contrast rules are broken here as well as in WCAG 2. So I am not sure if it is intentional.

image

pbroom commented 1 year ago

I have the exact same problem. Chroma and Tone seem to jump to an unknown locked position whenever I try to edit them.