material-motion-archive / family-direct-manipulation-android

Archived February 16, 2017 :: Direct manipulation plan types for Android devices
Apache License 2.0
1 stars 0 forks source link

Only set pivot point on gesture BEGAN, not every time on CHANGED #17

Closed pingpongboss closed 7 years ago

pingpongboss commented 7 years ago

Context: http://codereview.cc/D1986#inline-7881

pingpongboss commented 7 years ago

This is not possible. Because each GestureRecognizer has different slops, the moment BEGAN is called is different and thus the centroid at BEGAN is different for each GestureRecognizer.

Because each centroid is potentially different, one setPivot() in one BEGAN will be overwritten by the other setPivot() in another BEGAN. And this breaks the assumptions each GestureRecognizer makes.