search

material-motion-archive / starmap

Issue tracker for the starmap
https://material-motion.github.io/material-motion/
4 stars 0 forks source link

Writing plan information out to the console #73

Closed jverkoey closed 7 years ago

jverkoey commented 7 years ago

I've written up a spec on how plans might be written out to the console. View the spec here:

https://material-motion.github.io/material-motion/starmap/specifications/runtime/Runtime/tracing/ConsoleLoggingTracer

And an implementation of the proposed changes here: http://codereview.cc/D1897

jverkoey commented 7 years ago

LGTM via @pingpongboss in Discord.

appsforartists commented 7 years ago

We're accepting specs via Discord now? This is marked "stable," and I hadn't even seen it.

jverkoey commented 7 years ago

This one's pretty light-weight. Can re-open any thread with additional thoughts.

appsforartists commented 7 years ago

It's easy enough to bikeshed over the syntax (e.g. why let), but probably not substantive enough to be worthwhile.

Not sure what @ means as a type though.

jverkoey commented 7 years ago

Removed the lets.

jverkoey commented 7 years ago

http://codereview.cc/D1930

appsforartists commented 7 years ago

Thanks. What's @ as a type mean?

jverkoey commented 7 years ago

In swift-land is just an "unknown" type.