material-motion / material-motion-android

Reactive motion for Android. Deprecated; please use the Motion library in Material Components for Android instead: https://material.io/develop/android/theming/motion/.
Apache License 2.0
444 stars 26 forks source link

Use WeakHashMap for MotionRuntime's target-based caches #76

Closed pingpongboss closed 7 years ago

pingpongboss commented 7 years ago

MotionRuntime.cachedReactiveViews and MotionRuntime.cachedInteractions should both use WeakHashMap instead of SimpleArrayMap.

We do not want to prevent the target Object from being garbage collected. See https://github.com/material-motion/material-motion-android/blob/develop/library/src/main/java/com/google/android/material/motion/ReactiveProperty.java#L36