material-motion / material-motion-swift

A toolkit for building responsive motion using Core Animation.
Apache License 2.0
1.42k stars 79 forks source link

Added convenience constructor that takes DispatchTimeInterval for dur… #107

Closed randcode-generator closed 7 years ago

randcode-generator commented 7 years ago

…ation

Summary: We currently use CGFloat for duration but we wanted to include DispatchTimeInterval because of it’s cleaner time APIs.

Tags: #material_motion

Usage: delay(by: .milliseconds(500)) delay(by: .seconds(1))

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


randcode-generator commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

codecov[bot] commented 7 years ago

Codecov Report

Merging #107 into develop will increase coverage by 0.1%. The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #107     +/-   ##
==========================================
+ Coverage     27.3%   27.41%   +0.1%     
==========================================
  Files           80       81      +1     
  Lines         2227     2251     +24     
==========================================
+ Hits           608      617      +9     
- Misses        1619     1634     +15
Impacted Files Coverage Δ
src/interactions/TransitionTween.swift 0% <0%> (ø) :arrow_up:
src/interactions/PathTween.swift 0% <0%> (ø) :arrow_up:
src/interactions/Tween.swift 0% <0%> (ø) :arrow_up:
src/operators/delayBy.swift 100% <100%> (ø) :arrow_up:
src/common/DispatchTimeIntervalToSeconds.swift 50% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0c67c3...d5c90cb. Read the comment docs.

jverkoey commented 7 years ago

Awesome!

jverkoey commented 7 years ago

Will merge once Travis CI has returned with the results.