material-table-core / core

Datatable for React based on material-ui's table with additional features. Support us at https://opencollective.com/material-table-core
https://material-table-core.github.io
MIT License
296 stars 146 forks source link

Pagination localization labelDisplayedRows translation #630

Closed shaliake closed 2 years ago

shaliake commented 2 years ago

Translated value applies only in page navigation area

To Reproduce 1.Create localization object with translated values tableLanguage={...}

  1. Pass it to component: <MaterialTable title={"TITLE"} columns={[]} localization={tableLanguage} data={[]}/>
  2. We can notice that translation is not applied in red area: image

Expected behavior Area marked in red should be with same text as green Desktop (please complete the following information):

Domino987 commented 2 years ago

Can you put this into a sandbox s owe can reproduce it and know which version you are using etc? Can you check again?

shaliake commented 2 years ago

The sandbox is in place. My concrete dependencies from package.json:

    "@emotion/react": "^11.10.4",
    "@emotion/styled": "^11.10.4",
    "@fontsource/roboto": "^4.5.8",
    "@material-table/core": "^0.2.35",
    "@mui/icons-material": "^5.10.3",
    "@mui/material": "^5.10.4"

image But snippet in codesandbox is a bit different: image

Only one "x of y" section, somehow Rows per page is displayed, but not translated, in my local it's not even shown. Send help @Domino987 please open this issue again...