material-theme / vsc-material-theme

Material Theme, the most epic theme for Visual Studio Code
https://www.material-theme.dev
Other
11.2k stars 790 forks source link

Make notebook cells and their active state more distinguishable #1257

Closed paw-lu closed 1 year ago

paw-lu commented 1 year ago

Is your feature request related to a problem? Please describe. Compared to other themes, it's harder to easily scan when a cell is active in notebook mode.

SCR-20221222-fn6

Describe the solution you'd like

Something that mirrors the default vs code theme:

  1. If a cell is active we border it with the highlight color (teal in this example)
  2. Instead of a very thin black border in inactive cells, we give all cells a darker background. We get something like this by using the higher contrast variants of the themes, but I feel like notebooks are a special case that warrant the extra contrast and need the visial seperation. Alternative is that we use a lighter color border instead of chaning the background color.
SCR-20221222-fy3

Describe alternatives you've considered Using the higher contrast variants of the theme distinguish cells a bit more, but doesn't really help with distinguising the active cell (it's actually a bit harder for me).

SCR-20221222-fwn
open-collective-bot[bot] commented 1 year ago

Hey @paw-lu :wave:,

Thank you for opening an issue. We will get back to you as soon as we can. Have you seen our Open Collective page? Please consider contributing financially to our project. This will help us involve more contributors and get to issues like yours faster.

https://opencollective.com/material-theme

We offer priority support for all financial contributors. Don't forget to add priority label once you become one! :smile:

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.