material-theme / vsc-material-theme

Material Theme, the most epic theme for Visual Studio Code
https://www.material-theme.dev
Other
11.21k stars 788 forks source link

Issue with macro bracket color inconsistency #1270

Closed nowheredevel closed 1 year ago

nowheredevel commented 1 year ago

Describe the bug I've only noticed this issue in Rust, but when using proc macros in Rust there appears to be a coloring issue in all Material themes where the first bracket and last bracket have different colors.

To Reproduce Steps to reproduce the behavior:

  1. Install any Material theme, community or official
  2. Create a new rust file or project, doesn't matter as long as you're editing a Rust file
  3. Use any proc macro with this form: #[...]
  4. The first bracket will be a different color than the last bracket, which shouldn't happen in my opinion.

Expected behavior Ideally, when given a pair of brackets, the first and last bracket should be the same color. When using the Material theme and using brackets in other contexts, for example when creating an array, the first and last bracket are indeed the same color. In other themes, this consistency also applies to Rust's proc macros, however the Material theme doesn't keep this consistency.

Screenshots A proc macro having the described issue Another proc macro with the same issue

Additional context As mentioned before, almost every other theme I've used does not have this issue, so I hope this can be fixed. I apologize if this has been asked before.

equinusocio commented 1 year ago

Hello, we are not able to reproduce the issue with the native vscode rust language. If you're using an extension is probable that the extension is assigning the wrong scope to the brackets. We can't help with this, but you can try to override the color using the scope inspector, which may lead to unexpected coloring for other tokens.

CleanShot 2023-08-26 at 11 49 50