material-theme / vsc-material-theme

Material Theme, the most epic theme for Visual Studio Code
https://www.material-theme.dev
Other
11.21k stars 788 forks source link

After vscode 1.80 version,The parameter hint has changed from the original gray to the same white as the code font #1272

Closed EvilMoOd closed 1 year ago

EvilMoOd commented 1 year ago

Describe the bug After vscode 1.80 version, when turn on the parameter hint, the parameter color changes from the original gray to white. This problem will not appear in the version before 1.79. I hope to change the color back to the original gray, which is good for my code Very helpful reading, thanks a lot

Screenshots Before vscode 1.80 version f472121bb210f96fb0a9bd81e35909d after vscode 1.80 version 2d9f7f2d7ce052bdc45851548822d40 It's hard to tell if it's real code or a parameter hint

To Reproduce Steps to reproduce the behavior:

  1. open settings
  2. enabled inlay hints>Parameter Names image
  3. Write a function with parameters like above

Expected behavior I hope to see that the color of the parameter hintcan be less obvious than before, at least it can be distinguished from the real code color

Additional context I am useing Darker Theme

ArmorDarks commented 1 year ago

It is reproducible for me too, no extensions interfering with colors or syntax

equinusocio commented 1 year ago

Hello, we can't reproduce the issue with vscode 1.82. Please make sure you're using the correct and official material theme extension and not the "community maintained" one which was deprecated years ago and that we don't support since then.

CleanShot 2023-09-10 at 14 50 35

ArmorDarks commented 1 year ago

Thanks for checking @equinusocio

In my case, it's an official extension. Community extension not installed. VS Code 1.81.1 (Universal), MacOS Ventura 13.3 (22E252)

All hints in JS and TypeScript having wrong color too

image

Checked settings.json - no color overrides there.

ArmorDarks commented 1 year ago

Just to be sure, I tried with all extensions disabled + VS Code reload. Hint color still wrong:

image
ArmorDarks commented 1 year ago

Updating to VS Code 1.82 fixed the issue 👍

However, either I remember it wrong, or the color is not the one that's defined in the Material Theme.

Color in 1.82

image

Color prior to 1.80

image

equinusocio commented 1 year ago

We didn't change any syntax colors in years, so it's probably caused by semantic highlighting. Check the following setting, MT set semantic highlighting (the new way released months ago) to true by default, if you don't like it you can disable it.

Just keep note that this setting is just about how vscode assigns scopes to code elements, we have no control over this.

CleanShot 2023-09-11 at 10 00 21

It's also probable that they just changed the opacity of that token.. while the color still the same.