search

materialdigital / core-ontology

The PMD Core Ontology (PMDco) official release repository
15 stars 11 forks source link

Update the definitions of Sample, Specimen and Test Piece role #83

Closed MattTJung closed 4 months ago

MattTJung commented 5 months ago

Hi,

I updated the definitions of Sample Role, Specimen Role and Test Piece Role, after doing some research on how to differentiate between them. I documented my findings on the differences in Frame 70 of the co3.0.0 miro board.

Commit 71b77ab only updates the metadata.

Commit e678fb1 also adds axioms that incorporate the fact, that a Test Piece is manufactured from a Specimen/Sample and a Specimen is manufactured from a Sample. To do so, it was neccessary to import http://purl.obolibrary.org/obo/obi/2023-09-20/obi.owl to the manufacturing module. @joergwa @webhart I think it's worth discussing, if we really want to incorporate that.

See you, Matthias

MattTJung commented 5 months ago

PS: Sorry for the messed up diffs. In reality, the changes only affect the class definitions of Test Piece Role, Specimen Role, Sample Role. Please send me a hint if you think it's beneficial to clean that up before merging.

See you, Matthias

BerndBayerlein commented 4 months ago

@MarkusSchilling please have a look