search

materialscloud-org / aiida-explorer

Explore AiiDA databases through an interactive provenance browser
MIT License
7 stars 3 forks source link

[on hold ] Dark theme #35

Open hodovani opened 3 years ago

hodovani commented 3 years ago

The purpose of this PR is to add a dark theme to the app.

An example of dark theme:

image

An example of light theme:

image

A user can toggle theme with a button in menu:

image

ltalirz commented 3 years ago

thanks a lot @hodovani for this contribution! (and sorry for the dealy; these days were very busy)

I think a dark theme for materials cloud sounds like a great idea - we would just need to make it work across the website. I'll float the idea in the next materials cloud meeting on January 6th.

Until that point: I saw that you modified the mcloud_theme.css here - these changes should go in the frontend-theme repository. Apologies for the lack of modularity here, rather than having a copy of the mcloud_theme.min.css in this repo (as well as the header html + controllers), the header should really be its own package that is then used by the aiida-explorer (as well as the other frontend apps).

If you have suggestions on how to best go about that, they would be most welcome!

hodovani commented 3 years ago

@ltalirz thanks for links. I'll have a look at how we can use frontend-theme as a module :)

ltalirz commented 3 years ago

@hodovani I brought up your suggestion in the Materials Cloud meeting and there were no objections - so we are free to go ahead and roll it out across Materials Cloud :-)

However, as mentioned, this change will need to be made in the frontend-theme repository and then imported here.

I'm usually programming in python, and the default package manager pip allows to install packages directly from github. Could one build something similar, where the frontend-theme package is somehow npm-installed from github into the frontend apps?

P.S. Happy new year!

hodovani commented 3 years ago

@ltalirz Sorry, creating a separate module with the styles would take more time than I have at the moment. I hope to return to this at some point in future...

ltalirz commented 3 years ago

No worries, I also chatted with Evgeny - let's see whether someone from our team will find the time to do this refactoring at some point. I'll leave the PR open for the moment

blokhin commented 5 months ago

@eimrek same as #37