materialscloud-org / discover-curated-cofs

Materials Cloud DISCOVER section for CURATED COFs database
https://www.materialscloud.org/discover/curated-cofs
1 stars 0 forks source link

switch isotherm plot to bokeh #17

Closed ltalirz closed 4 years ago

ltalirz commented 4 years ago

change isotherm plot from matplotlib to bokeh. matplotlib plot was taking ~1s of total load time, also was non-interactive.

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

ltalirz commented 4 years ago

@danieleongari I switched the isotherm plot from matplotlib to bokeh. can you have a look and let me know whether this is ok?

I'm not sharing the axes here since it is more tedious to do in bokeh - but it can be done if needed, see here

ltalirz commented 4 years ago

matplotlib

Screenshot 2019-10-10 at 20 48 00

bokeh

Screenshot 2019-10-10 at 20 47 37
danieleongari commented 4 years ago

This looks really nice! Thanks!