search

materialscloud-org / discover-curated-cofs

Materials Cloud DISCOVER section for CURATED COFs database
https://www.materialscloud.org/discover/curated-cofs
1 stars 0 forks source link

add link to paper in select-figure and update papers csv #22

Closed danieleongari closed 4 years ago

danieleongari commented 4 years ago

Now select-figure has a link to the paper when clicking on the name, making it more appealing.

Moreover, I updated the cof-papers csv due to a missing reference (https://github.com/danieleongari/CURATED-COFs/commit/a1ee4b4bc38a70348b1d7f61fe05d5cc22db963d)

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

ltalirz commented 4 years ago

thanks @danieleongari ! Since you're not accessing the csv via the web but via python, could you please simply reuse the one we already have in the repository? Duplicating a file like this almost inevitably leads to issues.

Since the file no longer belongs to one particular view, perhaps move it to the ./data subfolder?

danieleongari commented 4 years ago

Done and tested.