search

materialscloud-org / voila-materialscloud-template

The Voila template for Materials Cloud.
Other
2 stars 3 forks source link

Set min-height for loading class #28

Closed CasperWA closed 3 years ago

CasperWA commented 3 years ago

Fixes #25.

The loading class contains the spinner.

Update text of spinner to accommodate the flexbox of the loading class.

CasperWA commented 3 years ago

@giovannipizzi After looking more into this, I found that the issue may not be the div, since it should already be present in the HTML here. It's more about the height of the "loading" class element, which is set to 75vh. I have now added a min-height property to 225px and cleaned up the text a bit.

I have no idea how to properly check this with out iframe set up locally, is there a way we can run this locally with the same settings and set up as we use on Materials Cloud?

giovannipizzi commented 3 years ago

That's the goal of dev-www and the matcloud.xyz domain - feel free to test there as much as you want, but then merge in production (materialscloud.io) only when you make a 'release' i.e. only stable versions.

If in the future this becomes too cumbersome we can create a small local emulation of the iframe, but I don't know if it's needed now (It's not hard, anyway - just a simple page with the iframeresizer library essentially).