search

materialsinnovation / pymks

Materials Knowledge System in Python
https://pymks.readthedocs.io/
Other
115 stars 76 forks source link

The domain argument in basis functions should really be range #327

Closed wd15 closed 7 years ago

wd15 commented 7 years ago

Domain is associated with spatial regions. State space should be referred to as a range. A user reported to me that this caused a lot of confusion when debugging in a code that uses PyMKS.

davidbrough1 commented 7 years ago

There are cases with the spectral bases it is useful to only include the most dominate the local states instead of a range. This is especially true for the GSHBasis class where the contribution from most of the influence coefficients is negligible as demonstrated in the polycrystal example.

wd15 commented 7 years ago

@davidbrough1, basically, what you are saying is that there is a valid reason to call the argument "domain" as opposed to "range"?