search

materialsinnovation / pymks

Materials Knowledge System in Python
https://pymks.readthedocs.io/
Other
115 stars 77 forks source link

build(nix): fix development environment #569

Closed wd15 closed 2 years ago

wd15 commented 2 years ago

The development environment was broken when using nix-shell. The version of pymks used was from the nix store not from the local working repository unless running python from withing the local base working repository. This showed up when running a notebook. The imported pymks was the nix store installed version at the time of running nix-shell and didn't include any edits to the working copy. Using filterSource to filter the source tree was doing something so that buildPythonPackage didn't recognize that the pymks was a development environment. cleanSource seems to avoid that problem.

wd15 commented 2 years ago

@beyucel this fixes that issue we were having with the development environment in the notebooks.

wd15 commented 2 years ago

The pip_install failure has nothing to do with this change, obviously.

beyucel commented 2 years ago

@beyucel this fixes that issue we were having with the development environment in the notebooks.

Meaning we don't have to restart the nix-shell after making changes on *.py files right?

wd15 commented 2 years ago

We also need to move from Travis CI to GitHub Actions. We may have run out of Travis CI cycles.

wd15 commented 2 years ago

@beyucel this fixes that issue we were having with the development environment in the notebooks.

Meaning we don't have to restart the nix-shell after making changes on *.py files right?

Yes

wd15 commented 2 years ago

The pip failure might be to do with scikit-learn not being available for Python 3.9 using pip according to this .