materialsinnovation / pymks

Materials Knowledge System in Python
https://pymks.readthedocs.io/
Other
115 stars 77 forks source link

Update Nix to 22.05 #576

Closed wd15 closed 2 years ago

wd15 commented 2 years ago

A change was required due to a change in the Sfepy API. Using a custom Sfepy version (not Nix version as that's broken in 22.05 (but fixed on master)).

Other things:

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

wd15 commented 2 years ago

The actions are running here, https://github.com/wd15/pymks/actions

It's not showing up in the boxes for some reason. Probably will work when this is merged.

wd15 commented 2 years ago

@beyucel : ready for your review now

beyucel commented 2 years ago

@wd15 I ran all the tests (code and notebooks). Only the graph-descriptors notebook failed. I think failure happened due to this error/warning distributed.nanny - WARNING - Restarting worker [on cells 11 and 12].

It computed the descriptors after the warning but got stuck at line 23 pipeline.fit. (I only ran that line 23 for 10 min)

I know this update is about fixing the sfepy but I wanted to let you know.

wd15 commented 2 years ago

@wd15 I ran all the tests (code and notebooks). Only the graph-descriptors notebook failed. I think failure happened due to this error/warning distributed.nanny - WARNING - Restarting worker [on cells 11 and 12].

It computed the descriptors after the warning but got stuck at line 23 pipeline.fit. (I only ran that line 23 for 10 min)

I know this update is about fixing the sfepy but I wanted to let you know.

Probably memory issues?