materialsintelligence / propnet

A knowledge graph for Materials Science.
Other
72 stars 23 forks source link

Symbol: change unit to preferred unit, include dimensionality #213

Open clegaspi opened 5 years ago

clegaspi commented 5 years ago

This change will clarify the unit in a symbol as a preference, not a requirement, as the requirement would be at the model level. In the docs, we will clarify that the choice of preferred unit establishes the typical magnitude of the material property, which is important for comparison of quantities of the same type to avoid floating point errors.

For unit dimensionality, we will expose pint's native "dimensionality" as a property of the symbol.

maxhutch commented 5 years ago

Pint's dimensionality functionality is great :-)