search

materialsintelligence / propnet

A knowledge graph for Materials Science.
Other
72 stars 23 forks source link

Fork pint's unit definitions into propnet #221

Closed mkhorton closed 5 years ago

mkhorton commented 5 years ago

We should really maintain our own independent unit definition file.

clegaspi commented 5 years ago

As opposed to just adding them programmatically like we do now.

mkhorton commented 5 years ago

To initialize the unit registry, pint references its constants_en.txt file, I'm just suggesting we make a copy of that file in our own repo and reference it.

This way we can add additional units to that file ourselves (for example, energy/atom) without having to clutter up the init.py which is where we currently do that, and it also means that we won't end up with inconsistent data if pint happens to change its unit definitions and we don't notice, e.g. updating a value for a fundamental constant.

mkhorton commented 5 years ago

Done