search

materialsproject / api

New API client for the Materials Project
https://materialsproject.github.io/api/
Other
107 stars 39 forks source link

Add back `additional_criteria` as an input to `get_entries` and `get_entries_in_chemsys` #693

Closed munrojm closed 1 year ago

munrojm commented 1 year ago

additional_criteria in top level entry related methods now passes arguments to MPRester.thermo.search

codecov-commenter commented 1 year ago

Codecov Report

Base: 85.67% // Head: 87.70% // Increases project coverage by +2.03% :tada:

Coverage data is based on head (c5bd46b) compared to base (9f821a1). Patch coverage: 84.84% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #693 +/- ## ========================================== + Coverage 85.67% 87.70% +2.03% ========================================== Files 36 36 Lines 1626 1667 +41 ========================================== + Hits 1393 1462 +69 + Misses 233 205 -28 ``` | [Impacted Files](https://codecov.io/gh/materialsproject/api/pull/693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject) | Coverage Δ | | |---|---|---| | [mp\_api/client/core/settings.py](https://codecov.io/gh/materialsproject/api/pull/693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9jb3JlL3NldHRpbmdzLnB5) | `88.88% <66.66%> (-11.12%)` | :arrow_down: | | [mp\_api/client/mprester.py](https://codecov.io/gh/materialsproject/api/pull/693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9tcHJlc3Rlci5weQ==) | `86.16% <86.66%> (+17.61%)` | :arrow_up: | | [mp\_api/client/routes/charge\_density.py](https://codecov.io/gh/materialsproject/api/pull/693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9yb3V0ZXMvY2hhcmdlX2RlbnNpdHkucHk=) | `65.07% <0.00%> (-23.81%)` | :arrow_down: | | [mp\_api/client/routes/tasks.py](https://codecov.io/gh/materialsproject/api/pull/693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9yb3V0ZXMvdGFza3MucHk=) | `90.90% <0.00%> (-4.55%)` | :arrow_down: | | [mp\_api/client/core/utils.py](https://codecov.io/gh/materialsproject/api/pull/693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9jb3JlL3V0aWxzLnB5) | `59.61% <0.00%> (+1.92%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.