materialsproject / api

New API client for the Materials Project
https://materialsproject.github.io/api/
Other
107 stars 39 forks source link

Insert missing comma in setup.py #697

Closed sezelt closed 1 year ago

sezelt commented 1 year ago

There is a missing comma on line 36 of setup.py that causes "emmet-core[all]>=0.36.4" and "custodian" to be interpreted as one string.

This then corrupts the poetry.lock that gets generated for projects that depend on mp-api, e.g.

[[package]]
name = "mp-api"
version = "0.29.2"
description = "API Server for the Materials Project"
category = "main"
optional = false
python-versions = ">=3.8"

[package.dependencies]
emmet-core = ">=0.36.4"
monty = ">=2021.3.12"
msgpack = "*"
pymatgen = ">=2022.3.7"
requests = ">=2.23.0"
typing-extensions = ">=3.7.4.1"

[package.extras]
all = ["boto3", "emmet-core[all] (>=0.36.4custodian)", "mpcontribs-client"]

yields

[...]
Installing dependencies from lock file

Could not parse version constraint: >=0.36.4custodian
munrojm commented 1 year ago

Thank you @sezelt!