materialsproject / api

New API client for the Materials Project
https://materialsproject.github.io/api/
Other
107 stars 39 forks source link

Fix MPRester doc string for notify_db_version #746

Closed janosh closed 1 year ago

janosh commented 1 year ago

@munrojm The old MPRester was changed to log the queried MP DB version to ~/.mprester.log.yaml instead of ~/.pmgrc.yaml. How about the new Rester? The doc string still mentioned the old location where it's definitely not logged to. But new Rester doesn't log at all?

Related: Was looking at the code due to this question https://matsci.org/t/46913.

munrojm commented 1 year ago

@janosh, I will take care of implementing this so it is consistent.

janosh commented 1 year ago

@munrojm This is ready to merge. Given the change affects only a doc string, the test failures are unrelated.