search

materialsproject / api

New API client for the Materials Project
https://materialsproject.github.io/api/
Other
104 stars 38 forks source link

Future type annotations #783

Closed janosh closed 12 months ago

janosh commented 1 year ago

Just a suggestion: Since this project is 3.8+, we could use more concise type annotations by adding the side-effect import to every file.

from __future__ import annotations
munrojm commented 1 year ago

@janosh Tried to wrestle with this a bit. There appears to still be a few problems, would you mind taking a closer look?

janosh commented 1 year ago

@munrojm Certainly. I just took a swing at it. Let me know if it helped.

janosh commented 1 year ago

@munrojm The error is now different and sounds like it's not caused by this PR?

Could not open requirements file: [Errno 2] No such file or directory: 'requirements/requirements-ubuntu-latest_py3.10_extras.txt'

munrojm commented 1 year ago

Yeah sorry, this will be resolved soon.

munrojm commented 12 months ago

This has been added