materialsproject / api

New API client for the Materials Project
https://materialsproject.github.io/api/
Other
104 stars 38 forks source link

Disable nested monty decode for some data #784

Closed munrojm closed 1 year ago

munrojm commented 1 year ago

This PR disables monty decoding for nested objects in tasks and provenance to fix issues related to varying schema. Objects with types defined in the pydantic models are still instantiated for these endpoints.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 69.14% and project coverage change: -2.49 :warning:

Comparison is base (98eb360) 81.05% compared to head (a4c0ce5) 78.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #784 +/- ## ========================================== - Coverage 81.05% 78.57% -2.49% ========================================== Files 36 38 +2 Lines 1758 1862 +104 ========================================== + Hits 1425 1463 +38 - Misses 333 399 +66 ``` | [Impacted Files](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject) | Coverage Δ | | |---|---|---| | [mp\_api/client/core/utils.py](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9jb3JlL3V0aWxzLnB5) | `59.61% <0.00%> (ø)` | | | [mp\_api/client/routes/\_user\_settings.py](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9yb3V0ZXMvX3VzZXJfc2V0dGluZ3MucHk=) | `100.00% <ø> (ø)` | | | [mp\_api/client/routes/charge\_density.py](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9yb3V0ZXMvY2hhcmdlX2RlbnNpdHkucHk=) | `67.16% <0.00%> (ø)` | | | [mp\_api/client/routes/electronic\_structure.py](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9yb3V0ZXMvZWxlY3Ryb25pY19zdHJ1Y3R1cmUucHk=) | `88.81% <ø> (ø)` | | | [mp\_api/client/routes/materials.py](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9yb3V0ZXMvbWF0ZXJpYWxzLnB5) | `68.57% <ø> (-7.15%)` | :arrow_down: | | [mp\_api/client/routes/summary.py](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9yb3V0ZXMvc3VtbWFyeS5weQ==) | `94.82% <ø> (-1.73%)` | :arrow_down: | | [mp\_api/client/routes/chemenv.py](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9yb3V0ZXMvY2hlbWVudi5weQ==) | `23.25% <23.25%> (ø)` | | | [mp\_api/client/routes/absorption.py](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9yb3V0ZXMvYWJzb3JwdGlvbi5weQ==) | `32.25% <32.25%> (ø)` | | | [mp\_api/client/routes/alloys.py](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9yb3V0ZXMvYWxsb3lzLnB5) | `52.63% <60.00%> (-6.20%)` | :arrow_down: | | [mp\_api/client/mprester.py](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-bXBfYXBpL2NsaWVudC9tcHJlc3Rlci5weQ==) | `59.13% <65.90%> (+0.33%)` | :arrow_up: | | ... and [27 more](https://codecov.io/gh/materialsproject/api/pull/784?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.