search

materialsproject / api

New API client for the Materials Project
https://materialsproject.github.io/api/
Other
104 stars 38 forks source link

Broken circular dependency versions #819

Open ml-evs opened 1 year ago

ml-evs commented 1 year ago

Just running into an issue with MP-API very indirectly via matminer, regardingly the migration of graph hashing code from emmet to pymatgen:

/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/emmet/core/utils.py:22: in <module>
    from pymatgen.util.graph_hashing import weisfeiler_lehman_graph_hash
E   ModuleNotFoundError: No module named 'pymatgen.util.graph_hashing'

matminer depends on mp_api indirectly via pymatgen, and mp_api depends on emmet and pymatgen itself.

A recent migration of code from emmet to pymatgen means that they can only be used together with versions pymtagen>=2023.5.8 and emmet>=0.57, but this package only pins emmet>=0.57. Could you please consider pinning pymatgen>=2023.5.8 explicitly too?

ml-evs commented 1 year ago

Here's how it appears for a user:

https://github.com/ppdebreuck/modnet/actions/runs/5299334192/jobs/9592225723?pr=154

munrojm commented 1 year ago

Yup, happy to change this. Thanks for the heads up.

ml-evs commented 1 year ago

Thanks @munrojm, hope my explanation was clear enough 😅