materialsproject / atomate2

atomate2 is a library of computational materials science workflows
https://materialsproject.github.io/atomate2/
Other
151 stars 86 forks source link

Advertising the atomate2 paper writing #750

Open Zhuoying opened 6 months ago

Zhuoying commented 6 months ago

Dear contributors,

We are thrilled to share the commencement of the Atomate2 paper's preparation phase. Our goal is to have the initial draft ready by our upcoming monthly gathering on March 29.

Since Atomate2 is truly a collective endeavor, we want to ensure that every contributor has the opportunity to contribute to the paper (including those who have made minor contributions but would like to do more to qualify for authorship).

Overview

The paper will be split into 5 sections:

  1. Introduction & Background (@computron)
  2. Atomate2 Design Philosophy & Overview (@utf)
  3. Calculators (team)
  4. Worklows (team)
  5. Conclusion & Future Work (@computron, @utf)

Below, you will find a list of teams categorized according to their workflow and calculator code contributions, compiled to the best of my knowledge. Should there be any oversight or additional workflows you've contributed to that are not mentioned, please do not hesitate to bring them to our attention.

Calculators

We kindly ask each calculator team to prepare the following:

Workflows

We kindly ask each workflow team to prepare the following:

Welcoming Additional Contributors

There are some contributors to atomate2 who have provided fixes here and there but who have not contributed to major workflows. We want to make it clear that these contributors are still welcome to be included on the atomate2 paper. However, we're suggesting that these people could contribute more to the atomate2 code base, either by fixing an open issue or by adding a new tutorial to the documentation. Currently, we could do with the following tutorials, however, if you have other ideas then please let @utf know.

If you think you could fit into this category, please reach out to @utf via email and we can chat.

List of tutorial contributors: @QuantumChemist, @ml-evs, @JonathanSchmidt1, @naik-aakash, @JaGeo

Notes

  1. We are delighted to hear your thoughts. For example, if you think anyone should be added to the authorship but not currently listed, don't hesitate to let us know.

  2. You are encouraged to collaborate within or across teams as you see fit. To simplify the collecting process, we propose nominating the first person listed in each workflow as the team leader by default. However, please feel free to adjust the leadership roles within your teams or to merge different workflow teams if you find it necessary. If any changes occur, we would appreciate a brief notification. I will make ongoing updates to the workflow list based on your feedback for a better track.

Point of contact for accessing collaboration platforms

Overleaf: Please leave your email to @utf for access to our Overleaf project. Zoom meeting: Please leave your email to @Zhuoying for the Google invite (our next meeting will be 8:30 AM on March 29 PST to discuss jobflow-remote and the paper writing) Slack channel: Please leave your email to @Andrew-S-Rosen for the Slack invite.

Your contributions are greatly valued. Any of your feedback and thoughts are welcome!

JaGeo commented 5 months ago

So as it turns out I was wrong and option(2) was much easier for a variety of reasons that were not obvious until I actually tried to do it for 10 mins.

I have implemented option (2) in a basic tutorial for blob storage #776, we can probably extend those trivially to mock the other codes.

This is great. I am looking forward to such tutorials.

JaGeo commented 5 months ago

We want everyone to update their sections by the next meeting (April 26). Overall, I'm expecting it will take until the May meeting to finalize things

@hrushikesh-s can you take care of reorganizing the paper into sections per the discussion? @hrushikesh-s can you also post an example of the type of diagrams expected for workflows of type A? You can just point to a particular workflow section in Overleaf if it helps

Thank you!

hrushikesh-s commented 5 months ago

The paper is now reorganized as Periodic/Molecular & Type A/B workflows!

Consider figures/anharmonic_phonon_worflow.pdf & figures/anharmonic_phonon_analysis.pdf as example figures for workflows of type A. I have also uploaded an editable template for the workflow figure in figures/template_workflow_figure.pptx

Also, pls feel free to update Tables 1 & 2 with workflows &/or supported calculators, if I have missed any!

We want everyone to update their sections by the next meeting (April 26). Overall, I'm expecting it will take until the May meeting to finalize things

@hrushikesh-s can you take care of reorganizing the paper into sections per the discussion? @hrushikesh-s can you also post an example of the type of diagrams expected for workflows of type A? You can just point to a particular workflow section in Overleaf if it helps

rkingsbury commented 5 months ago

We want everyone to update their sections by the next meeting (April 26). Overall, I'm expecting it will take until the May meeting to finalize things

Sounds good. Does this timeline also apply for drafting the tutorials?

@rdguha1995 how do you want to approach revising the Q-Chem sections? Is that in your court? My court? Do we need to make/modify figures? Let's coordinate offline.

jmmshn commented 4 months ago

Workflow template: template_workflow_figure.pptx

Color for dynamic workflow included on the side.

JaGeo commented 4 months ago

@jmmshn thank you! Awesome!

And sorry to all for joining late. The session at the MRS before went over time (finally being in a time zone that made the meeting possible)

mkhorton commented 4 months ago

Also missed due to MRS apologies, but will catch up from Janine.On Apr 26, 2024, at 11:02, J. George @.***> wrote: @jmmshn thank you! Awesome! And sorry to all for joining late. The session at the MRS before went over time (finally being in a time zone that made the meeting possible)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

computron commented 4 months ago

Hi all,

Here are the notes from Friday April 26 meeting:

Needs to be completed!

These are items that were not filled in at the time of needing and need urgently to be filled in

  1. MD section (combine AIMD, FFMD, and Classical MD) --> Orion, Guido, Mingjian, David
  2. MPMorph - Aaron
  3. GW / Excited states - Guido

Needs to be updated

We discussed Table 2 with the checkmarks. This table looks very sparse. Suggest to:

Suggest @janosh takes the lead or assigns to someone

Needs to be homogenized

We discussed the way figures should be formatted. The general consensus was to use the style of electrode insertion workflow in terms of color scheme / overall layout / level of detail of text. However some refinements to this style were also discussed:

Minor / TBD

janosh commented 4 months ago

Suggest @janosh takes the lead or assigns to someone

i get nightmares from latex tables! just so you know what you're asking...

jokes aside, i moved the most populated columns to the left (i.e. VASP) and merged the 4 ML columns (CHGNet, M3GNet, MACE, GAP) into 1 titled MLFFs (machine learning force fields), now explained in the caption (adding Nequip to the list).

i added a checkmark for the MLFF column in the equation of state row which is already implemented. i need input from others what they think would be easy to implement, i.e. where to place circles. here's what it currently looks like:

Screenshot 2024-04-30 at 15 58 34

rather than order columns by checkmark density, maybe better to order by association e.g. first-principles | ML | MD? i.e. vasp | cp2k | FHI-aims | Abinit | Q-Chem | MLFFs | OpenMM?

esoteric-ephemera commented 4 months ago

Now that there's an MPMorph PR submitted (still WIP but should be ready around submission time), I'd like to nominate @BryantLi-BLI to co-lead the MPMorph write up. Bryant has led much of the rewrite of these workflows. @utf and @Zhuoying, I can send Bryant's contact info over slack

@janosh:

Should we clarify that the MLFF stuff is now rewritten so that any ASE calculator works in these flows? That's now true for the relax, static, and MD MLFF jobs

AIMD and classical MD might be condensed into just MD (also think we're missing the AIMD implementations)

gpetretto commented 4 months ago

Hi, sorry, I could not make to the meeting, so I have a few questions concerning these points:

1. MD section (combine AIMD, FFMD, and Classical MD) --> Orion, Guido, Mingjian, David

Should these parts just be condensed in a single section? One potential issue is that classical MD is currently in the "Molecular systems" section, while AIMD is in the "Periodic systems" one. Where should the common section stay then? Since AIMD, FFMD and classical MD have a different workflow structure and different output documents, it would make sense to have multiple workflow diagrams associated with this section. Would that be fine for a single section?

3. GW / Excited states - Guido

Not sure why I was assigned the GW workflow. Is this correct?

JaGeo commented 4 months ago
3. GW / Excited states - Guido

Not sure why I was assigned the GW workflow. Is this correct?

@gpetretto I think we were confused about the responsibilty for the GW workflows. As currently, the VASP and Abinit versions are build, we were not sure who would write it. Thus, it is really rather an open question who should be responsible.

janosh commented 4 months ago

thanks @esoteric-ephemera, used triangles to indicate low implementation effort, circle for workflow-engine combos on atomate2's near-term road map (currently nothing, input welcome!) and combined the AIMD and classical MD rows into a single MD row. i put System = both in that row. the System column overall is low entropy. maybe drop it altogether? or make sure we're not missing any rows that should say "both" instead of "periodic"

Screenshot 2024-05-01 at 17 27 17

JaGeo commented 4 months ago

Just to mention it: LOBSTER could be run for a molecule with VASP as well. Abinit could likely be connected to the workflow as well but this would require some work from our side (a few days to.get lobsterin files for abinit).

gpetretto commented 4 months ago
3. GW / Excited states - Guido

Not sure why I was assigned the GW workflow. Is this correct?

@gpetretto I think we were confused about the responsibilty for the GW workflows. As currently, the VASP and Abinit versions are build, we were not sure who would write it. Thus, it is really rather an open question who should be responsible.

I have checked with @tatha0003, who is the author of the PR for the GW workflows for Abinit (https://github.com/materialsproject/atomate2/pull/816). He would be interested to contribute the section for the GW workflow of the paper. Not sure if anyone that wrote the VASP implementation is interested. If this is fine, I will send the email to add him to overleaf.

JaGeo commented 4 months ago

@naik-aakash has now updated the figures on the LOBSTER and Phonon workflow. If there is already feedback, let us know. Otherwise, we will wait for the next meeting.

JaGeo commented 3 months ago

Hi all, As the next meeting is coming up: I just looked at the draft. There is information on the GW calculations in texts on the calculators, but the GW/Excited States Section is still completely empty.

tatha0003 commented 3 months ago

Hi @JaGeo I will try to complete the abinit GW and BSE workflow section by the end of this week.

JaGeo commented 3 months ago

Thank you, @tatha0003 ! 😀

fraricci commented 3 months ago

Hi there!

I'd like to update the FE workflow picture. What's the right template to use? I see at least 3 different ones used so far in figs. 7, 3, 5.

Thanks

JaGeo commented 3 months ago

Hi there!

I'd like to update the FE workflow picture. What's the right template to use? I see at least 3 different ones used so far in figs. 7, 3, 5.

Thanks

@fraricci : https://github.com/materialsproject/atomate2/issues/750#issuecomment-2079838319 :)

utf commented 3 months ago

Hi everyone, these are the notes from the meeting on the 3rd June.

MD section

MPMorph

GW/Excited states

VASP calculator section

Table 2

Workflow diagrams

Timeframe

yanghan234 commented 3 months ago

Add VASP GW description. @yanghan234 are you happy to do this?

Sure, glad to contribute!

rkingsbury commented 2 months ago

QChem geometry optimisation (@rdguha1995, @rkingsbury, @rohithsrinivaas)

2 questions regarding this item -

  1. Are we going to eliminate the current Figure 1? I don't see figures like this for the other calculators anymore image

  2. Assuming 1 is true, we just need to port the existing FFOpt figure into the template. I'm happy to work on that, but @rdguha1995 @rohithsrinivaas can whichever one of you has the source files for the original figure please send them to me? image

rdguha1995 commented 2 months ago

Hey @rkingsbury! I agree. I think when I was writing that section, a figure for each calculator was preferred. I can go ahead and remove that. @rohithsrinivaas - Can you coordinate with Ryan on the FFOpt workflow figure? In my opinion, it would be easiest for Rohith to adapt it into the current template.

rohithsrinivaas commented 2 months ago

@rkingsbury I have updated the overleaf document with workflow diagram, adapting it to the current template. The pptx is in atomate2/figures_pptx_versions in the overleaf

image

rkingsbury commented 2 months ago

Thanks very much @rohithsrinivaas !

rkingsbury commented 2 months ago

The paper is looking good! I made minor edits to the Q-Chem sections this morning. I don't expect to have further input before submission (but will happily iterate on the tutorial referenced above and answer any questions). It's unlikely I'll be able to attend the meeting tomorrow.

rdguha1995 commented 2 months ago

I will also not be able to make it to the meeting tomorrow. I will have a chat with @rohithsrinivaas about the meeting minutes if this is the final one before we submit and I am happy to contribute to any further edits and future revisions. Fingers crossed and Best of Luck for the submission Team! 🤞

mkhorton commented 1 month ago

Adding a brief note that I met some researchers from University of Colorado, Boulder and NREL who are developing a JDFTx workflow for atomate2 (supports grand canonical DFT for electrochemistry), expecting PR relatively soon.

I realise this will not be in time for submission, but perhaps during revision if this work is sufficiently advanced by then? In either case wanted to mention it so that it's on the radar.

mkhorton commented 1 month ago

I'm reviewing the current draft and wondering if anyone has a list of workflows that are present in atomate1 that have not yet been ported to atomate2?