search

materialsproject / crystaltoolkit

Crystal Toolkit is a framework for building web apps for materials science and is currently powering the new Materials Project website.
https://docs.crystaltoolkit.org
Other
135 stars 57 forks source link

Difficult to find the Export 3D object option #347

Open computron opened 1 year ago

computron commented 1 year ago

The export 3D format option is currently under the snapshot sidebar and not under the Export sidebar. It makes it difficult to find or discover that the crystal can be exported to 3D formats. Suggest moving it to the export button. The snapshot icon to me means more like copying image to clipboard.

janosh commented 1 year ago

I think the current split is based on media vs non-media exports. The export icon only shows readable export formats.

Screenshot 2023-06-20 at 2 43 28 PM

I'm not sure this separation is helpful. I think we could throw it all together into a single "Export" dropdown.

This would need to be changed in https://github.com/materialsproject/mp-react-components.

mkhorton commented 11 months ago

The distinction perhaps makes more sense for the developer than from the user: bitmap or 3D graphics exports are handled client-side by Three.js, whereas the file exports are handled serverside via pymatgen.

They call completely different code paths. Combining them into a single dropdown is therefore a little trickier, because it would require hard-coding some things in JavaScript that are currently defined dynamically via Python (the pymatgen output formats).