search

materialsproject / crystaltoolkit

Crystal Toolkit is a framework for building web apps for materials science and is currently powering the new Materials Project website.
https://docs.crystaltoolkit.org
Other
135 stars 57 forks source link

Duplicate RGB values for elements in ElementColorSchemes.yaml #359

Open tsmathis opened 11 months ago

tsmathis commented 11 months ago

Two sets of two elements share duplicate RGB values in the VESTA color scheme in ElementColorSchemes.yaml. This leads to visual ambiguity in the rendered structures for materials with these elements in their chemical system.

VESTA: F and N : [176, 185, 230] Sr and Zr: [0, 255, 0]

Some examples: mp-770419, mp-601344

mkhorton commented 11 months ago

This is true, but not our choice: these are reference color schemes determined by others.

I completely support the addition of a new Crystal Toolkit color scheme however, which we can make a default. Happy to discuss.

mkhorton commented 11 months ago

Aside: this partly motivated the addition of the “Accessible” color scheme. This used a reference color scheme from literature suitable for people with color blindness, and constrained atoms to be their “regular” color if possible (i.e. close to CPK, oxygen red etc.)

This scheme is not fully successful yet since one of the colors in that scheme is white, so to really reach accessibility goals, it’d probably be better off switching to a black/darker viewport background when that scheme is enabled, or simply changing the white atom color to something else, but this was on the backlog.

tsmathis commented 11 months ago

Good to know. Color schemes came up in a MP update call a few weeks ago in a related context, I can bring it up again in the next call to see what everyone thinks.