materialsproject / crystaltoolkit

Crystal Toolkit is a framework for building web apps for materials science and is currently powering the new Materials Project website.
https://docs.crystaltoolkit.org
Other
149 stars 59 forks source link

Fix for missing spots in TEMDiffraction #366

Closed sezelt closed 1 year ago

sezelt commented 1 year ago

Checklist

Work-in-progress pull requests are encouraged but please mark your PR as draft.

Usually, the following items should be checked before merging a PR:

We recommended installing pre-commit to run all our linters locally. That will increase your development speed since you don't have to wait for our CI to tell about errors, your code will be checked at commit time.

pip install -U pre-commit
pre-commit install
sezelt commented 1 year ago

Due to a threshold being left at the default value, in some structures there could be missing spots in the TEM diffraction calculator. This PR fixes that threshold, and uses a different structure in the example app to make it easier to check for the problem.

yang-ruoxi commented 1 year ago

Looks good, thank you @sezelt