materialsproject / crystaltoolkit

Crystal Toolkit is a framework for building web apps for materials science and is currently powering the new Materials Project website.

https://docs.crystaltoolkit.org

Other

135 stars 57 forks source link

Added Coverage #391

Open jmmshn opened 1 month ago

jmmshn commented 1 month ago

Added pytest coverage report.

Still need a coverage token to be set.

Updated requirements files

Some minor fixes to make sure all the tests passed after the requirements update.

~~get_cmap was deprecated in matplotlib~~
phonopy is an option dependency of pymatgen so it should be added during testing.

jmmshn commented 1 month ago

https://github.com/materialsproject/crystaltoolkit/actions/runs/9122642016/job/25083746843?pr=391#step:8:50

I think we need to add a coverage token to this repo.

tschaume commented 1 month ago

@jmmshn I merged #392 and released a v2024.5.23rc2 to test the get_cmap deprecation in MP.

jmmshn commented 1 month ago

Thanks @tschaume, can you have a look at this one for me? I think the coverage is not triggering because we don't have the TOKEN but I do not have admin on this.

jmmshn commented 1 month ago

Looks like thinks should work once Ifermi is up to date with matplotlib.

tschaume commented 1 month ago

@jmmshn I put in a PR with IFermi: https://github.com/fermisurfaces/IFermi/pull/410