search

materialsproject / custodian

A simple, robust and flexible just-in-time job management framework in Python.
MIT License
136 stars 104 forks source link

AliasingErrorHandler checks for 'brmix' #270

Open xivh opened 1 year ago

xivh commented 1 year ago

The AliasingErrorHandler checks for a 'brmix' error, but this error is not in the error_msgs dictionary.

https://github.com/materialsproject/custodian/blob/202b941ab9c5d8fc3b9b9e5bb26a9e280ba1e0ea/custodian/vasp/handlers.py#L789C30-L789C30

Andrew-S-Rosen commented 1 year ago

@xivh: Thanks for reporting, but isn't it found here?

https://github.com/materialsproject/custodian/blob/202b941ab9c5d8fc3b9b9e5bb26a9e280ba1e0ea/custodian/vasp/handlers.py#L73

xivh commented 1 year ago

I'm not sure because I haven't used the AliasingErrorHandler before, but I didn't see a way for it to get the status of the VaspErrorHandler. The line you linked is from the VaspErrorHandler's error_msgs.

Andrew-S-Rosen commented 1 year ago

Ah, I believe you're correct.