search

materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
49 stars 63 forks source link

Change default values in document model for TaskDocument.output.stress/forces #1011

Closed tsmathis closed 1 month ago

tsmathis commented 1 month ago

Pydantic will throw validation errors for older calculations where stress and forces were not calculated. An empty list as the default field causes pydantic to check the empty list for Matrix3D or Vector3D entries, which don't exist.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.24%. Comparing base (39be2f6) to head (e45d5b4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1011 +/- ## ======================================= Coverage 77.24% 77.24% ======================================= Files 75 75 Lines 4329 4329 ======================================= Hits 3344 3344 Misses 985 985 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsmathis commented 1 month ago

tests in core for migration_graph not passing due to pmg issue here. Will go ahead anyway since this is just for an rc