materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
49 stars 63 forks source link

setup.py fixes to include mp_potcar_stats in emmet-builders package #1019

Closed tsmathis closed 1 month ago

tsmathis commented 1 month ago

972 added in mp_potcar_stats.json.gz to emmet-builders/emmet/builders/vasp/ for use in the validation builder to enable validation of task documents without having a POTCAR library established. Due to what I am guessing is a pathing error in the setup.py for emmet-builders, this file was not being included in the package for emmet-builders.

Since there is actually just a single .json.gz file that we intend to include, explicitly including the file in MANIFEST.in gets us where we want to be.

Only concern is that by including the potcar stats file, the wheel for emmet-builders increases by roughly 3.3x (116kb -> 385kb, comparing pypi vs. test-pypi).

sdist size remains the same

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.56%. Comparing base (292e2f7) to head (f5a3deb). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1019 +/- ## ======================================= Coverage 88.56% 88.56% ======================================= Files 113 113 Lines 10303 10303 ======================================= Hits 9125 9125 Misses 1178 1178 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.