search

materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
53 stars 66 forks source link

Further bug fix for legacy task documents with no `calcs_reversed` field #1075

Closed esoteric-ephemera closed 1 month ago

esoteric-ephemera commented 1 month ago

Follow up to #1074: When the calcs_reversed field is None in legacy task documents, the inp_set search in TaskDoc.model_post_init fails because 'NoneType' object is not subscriptable (there's a call to access self.calcs_reversed as a list before it's determined if calcs_reversed is not None)

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.00%. Comparing base (d748a2d) to head (4e06e0a). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1075 +/- ## ======================================= Coverage 90.00% 90.00% ======================================= Files 143 143 Lines 13438 13441 +3 ======================================= + Hits 12095 12098 +3 Misses 1343 1343 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.