materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
53 stars 66 forks source link

force dynamic enum generation for emmet-core #1097

Closed tsmathis closed 3 weeks ago

tsmathis commented 3 weeks ago

adding the explicit call to importlib forces the full module import, and triggers the corresponding exception to autogenerate the enums.

the static import statement can cause importlib's bootstrapping to fail in environments that only partially initialize the module at startup

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.28%. Comparing base (1d490e0) to head (157bfd0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1097 +/- ## =========================================== + Coverage 72.66% 90.28% +17.61% =========================================== Files 77 147 +70 Lines 5015 14157 +9142 =========================================== + Hits 3644 12781 +9137 - Misses 1371 1376 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.