search

materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
53 stars 64 forks source link

Clear band structure data incrementally #807

Closed munrojm closed 1 year ago

munrojm commented 1 year ago

This PR attempts to relieve some of the memory pressure of the electronic structure builder by clearing the BS data incrementally in the get stage

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -3.88% :warning:

Comparison is base (2eb40fa) 90.97% compared to head (bd30ea4) 87.10%. Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #807 +/- ## ========================================== - Coverage 90.97% 87.10% -3.88% ========================================== Files 136 107 -29 Lines 11722 7218 -4504 ========================================== - Hits 10664 6287 -4377 + Misses 1058 931 -127 ``` [see 48 files with indirect coverage changes](https://app.codecov.io/gh/materialsproject/emmet/pull/807/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.