search

materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
52 stars 64 forks source link

Small pydantic related bug fixes and linting #836

Closed munrojm closed 11 months ago

codecov-commenter commented 11 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (dac2e71) 78.99% compared to head (8d4b4d1) 91.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #836 +/- ## =========================================== + Coverage 78.99% 91.34% +12.35% =========================================== Files 75 138 +63 Lines 4208 12745 +8537 =========================================== + Hits 3324 11642 +8318 - Misses 884 1103 +219 ``` | [Files](https://app.codecov.io/gh/materialsproject/emmet/pull/836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject) | Coverage Δ | | |---|---|---| | [emmet-core/emmet/core/elasticity.py](https://app.codecov.io/gh/materialsproject/emmet/pull/836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-ZW1tZXQtY29yZS9lbW1ldC9jb3JlL2VsYXN0aWNpdHkucHk=) | `86.69% <100.00%> (ø)` | | | [emmet-core/emmet/core/electronic\_structure.py](https://app.codecov.io/gh/materialsproject/emmet/pull/836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-ZW1tZXQtY29yZS9lbW1ldC9jb3JlL2VsZWN0cm9uaWNfc3RydWN0dXJlLnB5) | `93.88% <100.00%> (+55.00%)` | :arrow_up: | | [emmet-core/emmet/core/qchem/molecule.py](https://app.codecov.io/gh/materialsproject/emmet/pull/836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-ZW1tZXQtY29yZS9lbW1ldC9jb3JlL3FjaGVtL21vbGVjdWxlLnB5) | `93.71% <ø> (ø)` | | | [emmet-core/emmet/core/vasp/validation.py](https://app.codecov.io/gh/materialsproject/emmet/pull/836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-ZW1tZXQtY29yZS9lbW1ldC9jb3JlL3Zhc3AvdmFsaWRhdGlvbi5weQ==) | `70.37% <100.00%> (+43.20%)` | :arrow_up: | | [emmet-core/emmet/core/tasks.py](https://app.codecov.io/gh/materialsproject/emmet/pull/836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-ZW1tZXQtY29yZS9lbW1ldC9jb3JlL3Rhc2tzLnB5) | `86.58% <83.33%> (ø)` | | | [emmet-core/emmet/core/structure\_group.py](https://app.codecov.io/gh/materialsproject/emmet/pull/836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-ZW1tZXQtY29yZS9lbW1ldC9jb3JlL3N0cnVjdHVyZV9ncm91cC5weQ==) | `52.89% <0.00%> (ø)` | | ... and [71 files with indirect coverage changes](https://app.codecov.io/gh/materialsproject/emmet/pull/836/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.