search

materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
52 stars 64 forks source link

Remove the pymatgen<=2023.9.10 version pin from `emmet-core` #837

Closed Andrew-S-Rosen closed 11 months ago

Andrew-S-Rosen commented 11 months ago

See https://github.com/materialsproject/pymatgen/releases/tag/v2023.9.10, in which we removed the pydantic pin. So, given that emmet-core now supports pydantic 2, I have updated it to pymatgen>=2023.9.10.

codecov-commenter commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (c2fad96) 91.34% compared to head (e42a276) 90.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #837 +/- ## ========================================== - Coverage 91.34% 90.59% -0.76% ========================================== Files 138 108 -30 Lines 12745 9600 -3145 ========================================== - Hits 11642 8697 -2945 + Misses 1103 903 -200 ``` [see 46 files with indirect coverage changes](https://app.codecov.io/gh/materialsproject/emmet/pull/837/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

munrojm commented 11 months ago

I added the pin today due to an issue with using OBAlign from openbabel. @janosh fixed this, but we will have to wait for next release.

Andrew-S-Rosen commented 11 months ago

Makes sense! Thought it was included because of pydantic 👍 Will revisit when a new pmg version is released.