materialsproject / emmet

Be a master builder of databases of material properties. Avoid the Kragle.
https://materialsproject.github.io/emmet/
Other
53 stars 68 forks source link

Remove PyObject pydantic type from model type hints #838

Closed munrojm closed 1 year ago

munrojm commented 1 year ago

This type is deprecated and causing warnings.

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (c2fad96) 91.34% compared to head (edc7fb1) 91.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #838 +/- ## ========================================== - Coverage 91.34% 91.34% -0.01% ========================================== Files 138 138 Lines 12745 12744 -1 ========================================== - Hits 11642 11641 -1 Misses 1103 1103 ``` | [Files](https://app.codecov.io/gh/materialsproject/emmet/pull/838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject) | Coverage Δ | | |---|---|---| | [emmet-core/emmet/core/settings.py](https://app.codecov.io/gh/materialsproject/emmet/pull/838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-ZW1tZXQtY29yZS9lbW1ldC9jb3JlL3NldHRpbmdzLnB5) | `98.33% <100.00%> (-0.03%)` | :arrow_down: | | [emmet-core/emmet/core/vasp/validation.py](https://app.codecov.io/gh/materialsproject/emmet/pull/838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=materialsproject#diff-ZW1tZXQtY29yZS9lbW1ldC9jb3JlL3Zhc3AvdmFsaWRhdGlvbi5weQ==) | `70.37% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.