Closed janosh closed 10 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
2f6119b
) 91.35% compared to head (9396be4
) 91.35%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The issue with this is that the metadata model is inherited by a lot of other documents. This effectively destroys validation for them. Can we not just enable extra fields on TaskDocument
like we do with the VASP equivalent (https://github.com/materialsproject/emmet/blob/485638ec7bb688462eed9c35d5c443e22a84941f/emmet-core/emmet/core/tasks.py#L310)?
Fixes breaking
test_cclib_taskdoc
in https://github.com/materialsproject/atomate2/pull/548.Failing lines that require
allow='extra'
.2nd fix needed for
atomate2
tests following #853.